fix dash escape #225
Merged
fix dash escape #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: ryboe#224 Inside of a character range, escape `-` to be treated literally instead of as `[a-z]` range notation in Oniguruma
vrugtehagel
approved these changes
Jul 18, 2024
|
I'm not sure what the next step for this is. How does this get "workflow approval" ? |
|
It needs the approval of a maintainer to be merged. The maintainers work on this repository voluntarily, so sometimes it can take a little while until they have time to get to it. That said, I think @argyleink will see this PR soon enough and he'll likely merge it since it's only a small change. |
|
Got it; thank you! Didn't know if I needed to do something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #224
Inside of a character range, escape
-to be treated literally instead of as[a-z]range notation in Oniguruma